fix(agenda): all day event offsets, locale display #3695
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnyeanderson
force-pushed
the
agenda-fix
branch
from
79c204f to
8148008
Compare
|
@glemco it seems like you're the de facto owner of the agenda app, so mentioning you here :) |
glemco
approved these changes
Dec 13, 2024
tnyeanderson
force-pushed
the
agenda-fix
branch
2 times, most recently
from
e315cac to
2d4228f
Compare
|
Should be ready for a final review. Thanks! |
tnyeanderson
force-pushed
the
agenda-fix
branch
from
2d4228f to
4354d46
Compare
|
Forgot to increment version and add the changelog entry... NOW we are good :) |
|
@tnyeanderson did you forget to push? There's still only one changed file in this PR |
Currently, allDay events are off by one day for negative timezones. Per
the CalendarContract:
If allDay is set to 1 eventTimezone must be "UTC" and the time must
correspond to a midnight boundary.
For example, in GMT-2:00, an all day event on December 2nd (beginning at
00:00:00) will be wrongly displayed as starting on December 1st, since
the locale will determine that the event's start time is actually
22:00:00 on Dec 1.
Source:
https://developer.android.com/reference/android/provider/CalendarContract.Events.html
This commit:
* Corrects the offset back to UTC 00:00:00 for allDay events
* Fixes the conditional for single-day all day events in showEvent()
* Fixes the display of formatDateShort() for some English locales by
also removing any trailing commas or whitespace when the year is
removed
tnyeanderson
force-pushed
the
agenda-fix
branch
from
4354d46 to
bcf88c3
Compare
|
Sorry, was in a rush and didn't |
glemco
approved these changes
Dec 17, 2024
|
Nice work, thanks for the PR @tnyeanderson and the review @glemco! |
randyheydon
added a commit
to randyheydon/BangleApps
that referenced
this pull request
Apr 10, 2025
All-day events synchronized from Gadgetbridge always start at midnight UTC, which causes them to display as different days depending on time zone offset (specifically negative offsets display the date as one day early). This was previously fixed in the agenda app in pull request espruino#3695 (commit bcf88c3). This commit replicates that fix in the clockinfo that agenda provides.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, allDay events are off by one day for negative timezones. Per the CalendarContract:
For example, in GMT-2:00, an all day event on December 2nd (beginning at 00:00:00) will be wrongly displayed as starting on December 1st, since the locale will determine that the event's start time is actually 22:00:00 on Dec 1.
Source:
https://developer.android.com/reference/android/provider/CalendarContract.Events.html
This commit:
Corrects the offset back to UTC 00:00:00 for allDay events
Fixes the conditional for single-day all day events in showEvent()
Fixes the display of formatDateShort() for some English locales by also removing any trailing commas or whitespace when the year is removed